Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SciPy 2022 talk to presentations #2053

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Add SciPy 2022 talk to presentations #2053

merged 3 commits into from
Aug 26, 2022

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Aug 12, 2022

Description of proposed changes

Adds a link to the SciPy talk in the overview page.

Preview at https://pygmt-dev--2053.org.readthedocs.build/en/2053/overview.html#presentations

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks again @maxrjones for giving the presentation! It's just outstanding to see how far PyGMT has come along since 2017 😄

@weiji14 weiji14 changed the title Add SciPy talk to presentations Add SciPy 2022 talk to presentations Aug 12, 2022
@weiji14 weiji14 added the documentation Improvements or additions to documentation label Aug 12, 2022
@weiji14 weiji14 added this to the 0.8.0 milestone Aug 12, 2022
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Aug 12, 2022
@seisman
Copy link
Member

seisman commented Aug 13, 2022

Nice presentation!

For this PR, I feel the thumbnail image doc/_static/scipy2022-youtube-thumbnail.png is too large (834 KB) and should not be included in the repo.

@seisman
Copy link
Member

seisman commented Aug 13, 2022

For this PR, I feel the thumbnail image doc/_static/scipy2022-youtube-thumbnail.png is too large (834 KB) and should not be included in the repo.

The thumbnail image can be compressed to less than 100 KB using https://squoosh.app/.

doc/overview.rst Outdated Show resolved Hide resolved
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 24, 2022
@maxrjones maxrjones requested a review from seisman August 26, 2022 01:55
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Aug 26, 2022
@seisman seisman merged commit 461ad44 into main Aug 26, 2022
@seisman seisman deleted the scipy-talk branch August 26, 2022 14:20
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants